[zfs-discuss] Clang static analyze of zfs code

Will Rouesnel w.rouesnel at gmail.com
Tue May 1 09:52:11 EDT 2012


On 1/05/2012 10:29 PM, Richard Yao wrote:
> On 05/01/12 07:27, Marcin Mirosław wrote:
>> I've made new analyze with fresh clang and fresh zfs sources:
>> http://mejor.pl/zfs-710114089/
>> I noticed new kind of error "memory leak", unfortunately i have no C
>> skills to verify it.
>> Regards,
>> Marcin
> I looked at the first memory leak report and I can confirm that Clang's
> report is correct. The reported leaks are in userland programs. Those
> programs (usually) do not run very long, so memory leaks in them are
> minor issues.
>
> On the other hand, Clang is reporting "Dereference of null pointer" in
> kernel code, which are far more serious. For instance, the following
> issue that Clang highlighted shows that ARC can do a null pointer
> dereference if a memory allocation fails, which would result in a kernel
> panic:
>
> http://mejor.pl/zfs-710114089/report-KTmROK.html#EndPath
>
I'd just like to comment that this is pretty damn awesome. Maybe 
something to add to standard test suite on build?



More information about the zfs-discuss mailing list